Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Crdcdh 65 #98

Merged
merged 10 commits into from
Aug 28, 2023
Merged

Crdcdh 65 #98

merged 10 commits into from
Aug 28, 2023

Conversation

mtangmt
Copy link
Contributor

@mtangmt mtangmt commented Aug 22, 2023

This implements ticket 65.
To test, I modified either:

  • thresholdTime on line 124 of InactivityDialog.tsx, to be 1800
  • modified line 153 to be const ttl = data.ttl - 1790;

Modifying the threshold time to be 1800, means the warning dialog will pop up at 30 minutes left in the time (immediately).
Modifying the ttl received from the backend leaves only 10 seconds left (1800 - 1790 = 10) on the timer and then we can test both the warning dialog, and the session timeout.
To test the extension of the ttl, just console.log the ttl recieved from the backend.

@mtangmt mtangmt marked this pull request as draft August 22, 2023 22:26
@mtangmt
Copy link
Contributor Author

mtangmt commented Aug 22, 2023

After discussing with Kailing and updating the ticket requirements. We decided that the dialog pop-up made more sense for timeout, and that having a banner and the dialog was redundant.
So now, on timeout, the user is logged out, redirected to home page/# page, and only the dialogbox shows up.

@mtangmt mtangmt marked this pull request as ready for review August 22, 2023 22:45
@mtangmt mtangmt marked this pull request as draft August 28, 2023 16:03
@mtangmt mtangmt marked this pull request as ready for review August 28, 2023 18:29
@jonkiky jonkiky merged commit 568485a into mvp-1.0.0 Aug 28, 2023
@jonkiky jonkiky deleted the CRDCDH-65 branch August 28, 2023 19:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants