Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: show scheduled orders even if no pending results #2829

Merged
merged 3 commits into from
Oct 30, 2024
Merged

fix: show scheduled orders even if no pending results #2829

merged 3 commits into from
Oct 30, 2024

Conversation

mcmcgrath13
Copy link
Collaborator

PULL REQUEST

Summary

Always show all pending results and scheduled orders if available.

Related Issue

Fixes #2744

Additional Information

image

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

BobanL
BobanL approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits with leftover logs, but otherwise looks good!

containers/ecr-viewer/src/app/tests/utils.test.tsx Outdated Show resolved Hide resolved
containers/ecr-viewer/src/app/tests/utils.test.tsx Outdated Show resolved Hide resolved
@mcmcgrath13 @BobanL
Apply suggestions from code review
f0eaccd 
Co-authored-by: Boban <BobanL@users.noreply.github.com>
@mcmcgrath13
Copy link
Collaborator Author

A couple of nits with leftover logs, but otherwise looks good!

Whoops - thanks!

@mcmcgrath13 mcmcgrath13 added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 3cab256 Oct 30, 2024
11 checks passed
@mcmcgrath13 mcmcgrath13 deleted the mcm/sched-ord-2744 branch October 30, 2024 12:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@BobanL BobanL BobanL approved these changes

@lina-roth lina-roth Awaiting requested review from lina-roth lina-roth is a code owner

@gordonfarrell gordonfarrell Awaiting requested review from gordonfarrell gordonfarrell is a code owner

@JNygaard-Skylight JNygaard-Skylight Awaiting requested review from JNygaard-Skylight JNygaard-Skylight is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Scheduled orders not displaying
2 participants
@mcmcgrath13 @BobanL