Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: handle invalid telephone numbers #2868

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Conversation

mcmcgrath13
Copy link
Collaborator

@mcmcgrath13 mcmcgrath13 commented Nov 6, 2024

PULL REQUEST

Summary

When a telephone number exists, but can't be coerced into the expected format, return the string "Invalid Number" instead of undefined. Also add a : to separate use and value now that we can have words on both sides.

Related Issue

Fixes #2730

Additional Information

Before:
image

With Fix: (data mocked)
image

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

Copy link
Collaborator

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@mcmcgrath13 mcmcgrath13 added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit d2093ce Nov 6, 2024
11 checks passed
@mcmcgrath13 mcmcgrath13 deleted the mcm/fix-invalid-tel branch November 6, 2024 17:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Patient phone number isn't converting correctly
2 participants