fix: use teal lines in ECR summary box #2957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmcgrath13
requested review from
BobanL,
austin-hall-skylight,
angelathe,
lina-roth,
ashton-skylight,
gordonfarrell and
JNygaard-Skylight
and removed request for
BobanL and
austin-hall-skylight
|
Excellent work! |
BobanL
approved these changes
Nov 25, 2024
Comment on lines
48
to
53
| .section__line { | ||
| border-top: 1px solid #99DEEA; | ||
| margin-top: .5rem; | ||
| margin-bottom: .5rem; | ||
| } | ||
|
|
There was a problem hiding this comment.
Would it be too far out of scope of this work to just remove this class and replace it with .section__line_teal? If you think it's too much right now that's fine.
There was a problem hiding this comment.
I think that's in scope - I'm all for clean up things while you're there (within reason)
There was a problem hiding this comment.
fixed! and a lot extra
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Use teal lines in ECR summary box, per design. Achieved by adding a
themeColorprop toDataDisplayandDataTableDisplayleaving a default of"gray".Related Issue
Fixes #2626
Additional Information