Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update integration tests to run at the current commit in CI #871

Merged
merged 6 commits into from
Oct 18, 2023

Conversation

emmastephenson
Copy link
Collaborator

@emmastephenson emmastephenson commented Oct 17, 2023

PULL REQUEST

Summary

When running tests in CI, install from @{current_commit} instead of main.

Related Issue

This fixes an issue where a breaking SDK change for the containers is only discovered after merge to main. For instance:

  1. An SDK change is made; integration tests pass locally and on CI (because they're installing PHDI from @main)
  2. The SDK PR is merged into main
  3. Container integration tests run and fail, because main@phdi now contains breaking changes.

Additional Information

This will only affect integration tests running in CI - local tests will still install from @main. (Warning here in case of future "it works on my machine")

CI before:
Screenshot 2023-10-17 at 4 44 28 PM

CI after:
Screenshot 2023-10-17 at 4 43 36 PM

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #871 (d6eba92) into main (9f9ad69) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #871   +/-   ##
=======================================
  Coverage   96.37%   96.37%           
=======================================
  Files          46       46           
  Lines        2648     2648           
=======================================
  Hits         2552     2552           
  Misses         96       96           
Flag Coverage Δ
unit-tests 96.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@DanPaseltiner DanPaseltiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @emmastephenson!

@emmastephenson emmastephenson merged commit dcc49cb into main Oct 18, 2023
20 checks passed
@emmastephenson emmastephenson deleted the emma/integration-ci-update branch October 18, 2023 20:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants