14601 authorization api #16495
Open
14601 authorization api #16495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m:CDCgov/prime-reportstream into platform/jamie/15864-spring-cloud-swagger
…m:CDCgov/prime-reportstream into platform/jamie/15864-spring-cloud-swagger
…m:CDCgov/prime-reportstream into platform/jamie/15864-spring-cloud-swagger
jalbinson
commented
Nov 6, 2024
auth/src/main/kotlin/gov/cdc/prime/reportstream/auth/service/OktaGroupsJWTWriter.kt
Show resolved
Hide resolved
jalbinson
commented
Nov 6, 2024
auth/src/main/kotlin/gov/cdc/prime/reportstream/auth/service/OktaGroupsService.kt
Show resolved
Hide resolved
jalbinson
commented
Nov 6, 2024
jalbinson
commented
Nov 6, 2024
jalbinson
commented
Nov 6, 2024
jalbinson
commented
Nov 6, 2024
shared/src/main/kotlin/gov/cdc/prime/reportstream/shared/auth/AuthZService.kt
Show resolved
Hide resolved
…ime-reportstream into platform/jamie/14601-authz-api
jalbinson
added
the
microservice
adegolier
reviewed
Nov 14, 2024
| .setClientId(oktaClientProperties.clientId) | ||
| .setScopes(oktaClientProperties.requiredScopes) | ||
| .setPrivateKey(oktaClientProperties.apiPrivateKey) | ||
| // .setCacheManager(...) TODO: investigate caching since groups don't often change |
There was a problem hiding this comment.
Is there a ticket for this?
There was a problem hiding this comment.
I would just leave this be for now. Caching is something we can worry about if performance becomes a problem especially since this is currently a POC.
...st/kotlin/gov/cdc/prime/reportstream/auth/filter/AppendOktaGroupsGatewayFilterFactoryTest.kt
Show resolved
Hide resolved
| path: /swagger/api-docs | ||
|
|
||
| #Uncomment for verbose logging |
There was a problem hiding this comment.
This appears to be uncommented already, is that intentional?
There was a problem hiding this comment.
Nope, good catch. It's helpful for debugging as it spits out tons of logs.
submissions/src/test/kotlin/SubmissionControllerIntegrationTest.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Arnej <118766341+arnejduranovic@users.noreply.github.com>
…ime-reportstream into platform/jamie/14601-authz-api
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds authorization functionality to the auth and submission microservices.
Test Steps:
Bonus points: run the tests in the auth and submissions project to ensure they are passing on your machine locally.
Changes
Checklist
Testing
./prime testor./gradlew testSmokeagainst local Docker ReportStream container?Linked Issues