Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove Apple Silicon check from cleanslate.sh #16605

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

halprin
Copy link
Member

@halprin halprin commented Nov 19, 2024

This PR removes the check for Apple Silicon from cleanslate.sh. For a few years now, x86, x86_64, and amd64 architecture Docker images run just fine through Rosetta 2 emulation. We've run all the images in ReportStream on Apple Silicon Macs without any problems for years. This check can be removed.

Test Steps:
Run cleanslate.sh on an Apple Silicon Mac.

Changes

  • Removed the Apple Silicon check from cleanslate.sh that made it only build a few services.

Checklist

Testing

  • Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • (For Changes to /frontend-react/...) Ran npm run lint:write?
  • Added tests?

Process

  • Are there licensing issues with any new dependencies introduced?
  • Includes a summary of what a code reviewer should test/verify?
  • Updated the release notes?
  • Database changes are submitted as a separate PR?
  • DevOps team has been notified if PR requires ops support?

Linked Issues

None.

To Be Done

None.

@halprin halprin added the platform Platform Team label Nov 19, 2024
@halprin halprin requested a review from a team as a code owner November 19, 2024 23:29
Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

Test Results

1 247 tests  ±0   1 243 ✅ ±0   7m 39s ⏱️ -9s
  162 suites ±0       4 💤 ±0 
  162 files   ±0       0 ❌ ±0 

Results for commit 30bd551. ± Comparison against base commit 9ae54e5.

Copy link

sonarcloud bot commented Nov 19, 2024

Copy link

Integration Test Results

 54 files   54 suites   27m 51s ⏱️
414 tests 404 ✅ 10 💤 0 ❌
417 runs  407 ✅ 10 💤 0 ❌

Results for commit 30bd551.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
platform Platform Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant