Remove Apple Silicon check from cleanslate.sh #16605
Open
+0
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the check for Apple Silicon from
cleanslate.sh
. For a few years now, x86, x86_64, and amd64 architecture Docker images run just fine through Rosetta 2 emulation. We've run all the images in ReportStream on Apple Silicon Macs without any problems for years. This check can be removed.Test Steps:
Run
cleanslate.sh
on an Apple Silicon Mac.Changes
cleanslate.sh
that made it only build a few services.Checklist
Testing
./prime test
or./gradlew testSmoke
against local Docker ReportStream container?npm run lint:write
?Process
Linked Issues
None.
To Be Done
None.