-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Issue 275: Prototype VARIMA (Analysis - do not merge) #291
Draft
SamuelBrand1
wants to merge
13
commits into
main
Choose a base branch
from
275-varima-baseline-model
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
==========================================
- Coverage 16.54% 15.87% -0.67%
==========================================
Files 21 21
Lines 1481 1537 +56
==========================================
- Hits 245 244 -1
- Misses 1236 1293 +57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR explores the VARIMA baseline model as per #275 and commits an analysis of different VARIMA structures across a few chosen dates with a few chosen ARIMA models aimed at covid and flu NHSN.
This is committed as an analysis here.
Whilst this is not an exhaustive analysis, it shows that the "best" model, as in what time series joint modelling configs have the best out-of-sample CRPS, varies over time and pathogen. This suggests that for multi-signal approaches we probably want to go towards some kind of ensemble over structures to have more consistent forecast performance.
From the pov of a baseline against pyrenew; SARIMA still seems reasonable because it was never the worst time series model.
Linking @seabbs because he was interested in VARIMA.