Bug fix create.py #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct issue where organism and collection date was being added to the comment.cmt file for genbank submissions
dthoward96
added a commit
that referenced
this pull request
Aug 6, 2024
* Create codeql-analysis.yml (#25) * Create codeql.yml (#29) * Dthoward96 workflow correction (#30) * Delete .github/workflows/codeql-analysis.yml * Delete .github/workflows/python-package-mamba.yml * Add files via upload (#31) * bug fix process.py (#32) Missing a return for config file function and correcting a error message to print the correct df * Create GHCR_docker.yml (#33) * Create GHCR_docker.yml * Update GHCR_docker.yml Correct changes for master branch * FTP folder bug fix submit.py (#34) Some FTP accounts have the folder structure /submit/Production/ instead of /Production/. This fix automatically corrects for this difference in folder structure. * update template metadata required fields + check submitting databases are valid * Update process.py removed the gs-sequence_name specified for flu * Create docker_test_build.yml (#41) automatic test builds dockerfile on pull request. This will prevent merging to master if Dockerfile fails to build correctly. * Dthoward96 org id patch (#42) * Update cov_config.yaml remove org_id from examples * Update flu_config.yaml remove org_id from examples * Update create.py remove org_id from xml creation * Dthoward96 bugfix (#45) * Update report.py Bug fix to allow for other submit folders in FTP of ncbi * Update process.py bug fix for capitalization of folder name * Add files via upload (#49) Changes requirement from only isolate to require either strain or isolate for BioSample and GenBank * create.py duplicate strain name bug (#50) Fixes issue that creates duplicate strain columns when using src-strain * Bug fix process.py (#51) Bug fix for upload log. When only one database was submitted it, it would convert the database name into a list and error out. * Bug fix for gisaid name overwriting genbank name for fasta file (#53) * Bug fix for gisaid name overwriting genbank name for fasta file * bug fix fasta file creation (#55) Fix issue where it requires fasta file for non-fasta submission * Bug fix create.py (#56) Correct issue where organism and collection date was being added to the comment.cmt file for genbank submissions * Table2asn bug fixes (#57) * Table2asn bug fixes Resolve issue with table2asn not allowing multiple sequences in the fasta file and for the table2asn sendmail function not properly grabbing the sqn file. * Update submit.py * V1.2.0 Update (#58) * Version updates * Env update * Delete .github/workflows/python-package-mamba.yml removing test yml * pandera schema update * Delete gisaid_cli/poxCLI directory * bug fixes * Delete FLU_test directory * Delete OTHER_species directory * Delete POX_species directory * mypy validation added * mypy integration * Shiny Update * Seqsender v1.2.0 website updates * Update README.md * Update README.md * shiny website updates * Seqsender shiny updates * V1.2.0 Prod Update --------- Co-authored-by: rchau88 <110563969+rchau88@users.noreply.github.com> Co-authored-by: snu3 <snu3@cdc.gov>
dthoward96
added a commit
that referenced
this pull request
Aug 6, 2024
* Update Dev to v1.2.0 (#59) * Create codeql-analysis.yml (#25) * Create codeql.yml (#29) * Dthoward96 workflow correction (#30) * Delete .github/workflows/codeql-analysis.yml * Delete .github/workflows/python-package-mamba.yml * Add files via upload (#31) * bug fix process.py (#32) Missing a return for config file function and correcting a error message to print the correct df * Create GHCR_docker.yml (#33) * Create GHCR_docker.yml * Update GHCR_docker.yml Correct changes for master branch * FTP folder bug fix submit.py (#34) Some FTP accounts have the folder structure /submit/Production/ instead of /Production/. This fix automatically corrects for this difference in folder structure. * update template metadata required fields + check submitting databases are valid * Update process.py removed the gs-sequence_name specified for flu * Create docker_test_build.yml (#41) automatic test builds dockerfile on pull request. This will prevent merging to master if Dockerfile fails to build correctly. * Dthoward96 org id patch (#42) * Update cov_config.yaml remove org_id from examples * Update flu_config.yaml remove org_id from examples * Update create.py remove org_id from xml creation * Dthoward96 bugfix (#45) * Update report.py Bug fix to allow for other submit folders in FTP of ncbi * Update process.py bug fix for capitalization of folder name * Add files via upload (#49) Changes requirement from only isolate to require either strain or isolate for BioSample and GenBank * create.py duplicate strain name bug (#50) Fixes issue that creates duplicate strain columns when using src-strain * Bug fix process.py (#51) Bug fix for upload log. When only one database was submitted it, it would convert the database name into a list and error out. * Bug fix for gisaid name overwriting genbank name for fasta file (#53) * Bug fix for gisaid name overwriting genbank name for fasta file * bug fix fasta file creation (#55) Fix issue where it requires fasta file for non-fasta submission * Bug fix create.py (#56) Correct issue where organism and collection date was being added to the comment.cmt file for genbank submissions * Table2asn bug fixes (#57) * Table2asn bug fixes Resolve issue with table2asn not allowing multiple sequences in the fasta file and for the table2asn sendmail function not properly grabbing the sqn file. * Update submit.py * V1.2.0 Update (#58) * Version updates * Env update * Delete .github/workflows/python-package-mamba.yml removing test yml * pandera schema update * Delete gisaid_cli/poxCLI directory * bug fixes * Delete FLU_test directory * Delete OTHER_species directory * Delete POX_species directory * mypy validation added * mypy integration * Shiny Update * Seqsender v1.2.0 website updates * Update README.md * Update README.md * shiny website updates * Seqsender shiny updates * V1.2.0 Prod Update --------- Co-authored-by: rchau88 <110563969+rchau88@users.noreply.github.com> Co-authored-by: snu3 <snu3@cdc.gov> * V1.2.0 Prod Update --------- Co-authored-by: rchau88 <110563969+rchau88@users.noreply.github.com> Co-authored-by: snu3 <snu3@cdc.gov>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct issue where organism and collection date was being added to the comment.cmt file for genbank submissions