Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bakta troubleshoot kyleoconnell #107

Merged

Conversation

kyleoconnell
Copy link
Collaborator

Description

fixed errors with bakta db download as well as bakta with user - supplied db.

Checklist

Go Through Checklist Below and Place A ✔️ (X Inside the Box) if Completed

General Checks

  • Have you run appropriate tests (unit/integration/end-to-end) to check logic across run environments (Conda/Docker/Singularity on Scicomp/AWS/NF Tower/Local)?

    For each relevant configuration:

    • Can the program run completely through without erroring out?
    • Does it produce the expected outputs, given the inputs provided?
  • Have you conducted proper linting procedures?

    • Numpy formatted docstrings for functions
    • Comments explaining lines of code
    • Consistent and intuitive naming conventions for variables, functions, classes, methods, attributes, and scripts
    • Single empty line between class functions, two lines between non-class functions, and two lines between imports and code body
    • Camel case formatting for class names
  • Have you updated existing documentation (README.md, etc.) or created new ones within docs?

CDC Checks

  • Did you check for sensitive data, and remove any?
  • If you added or modified HTML, did you check that it was 508 compliant?

Are additional approvals needed for this change? If so, please mention them below:

Are there potential vulnerabilities or licensing issues with any new dependencies introduced? If so, please mention them below:

@kyleoconnell kyleoconnell self-assigned this Jan 5, 2024
@kyleoconnell kyleoconnell changed the base branch from master to dev January 5, 2024 20:23
@kyleoconnell kyleoconnell marked this pull request as draft January 5, 2024 22:10
@ankushkgupta2 ankushkgupta2 marked this pull request as ready for review January 5, 2024 22:16
@ankushkgupta2 ankushkgupta2 marked this pull request as draft January 7, 2024 20:44
@kyleoconnell kyleoconnell changed the base branch from dev to dev-patch-remove-invalid-arg January 10, 2024 18:05
@kyleoconnell kyleoconnell marked this pull request as ready for review January 10, 2024 18:12
@kyleoconnell kyleoconnell merged commit 7fd6613 into dev-patch-remove-invalid-arg Jan 10, 2024
@kyleoconnell kyleoconnell deleted the bakta_troubleshoot_kyleoconnell branch January 12, 2024 15:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant