Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

merge bakta module fixes into dev #163

Merged
merged 18 commits into from
Feb 20, 2024
Merged

merge bakta module fixes into dev #163

merged 18 commits into from
Feb 20, 2024

Conversation

jessicarowell
Copy link
Collaborator

Description

Please Describe the Bug(s) Fixed and/or the Feature(s) Added:

Checklist

Go Through Checklist Below and Place A ✔️ (X Inside the Box) if Completed

General Checks

  • Have you run appropriate tests (unit/integration/end-to-end) to check logic across run environments (Conda/Docker/Singularity on Scicomp/AWS/NF Tower/Local)?

    For each relevant configuration:

    • Can the program run completely through without erroring out?
    • Does it produce the expected outputs, given the inputs provided?
  • Have you conducted proper linting procedures?

    • Numpy formatted docstrings for functions
    • Comments explaining lines of code
    • Consistent and intuitive naming conventions for variables, functions, classes, methods, attributes, and scripts
    • Single empty line between class functions, two lines between non-class functions, and two lines between imports and code body
    • Camel case formatting for class names
  • Have you updated existing documentation (README.md, etc.) or created new ones within docs?

CDC Checks

  • Did you check for sensitive data, and remove any?
  • If you added or modified HTML, did you check that it was 508 compliant?

Are additional approvals needed for this change? If so, please mention them below:

Are there potential vulnerabilities or licensing issues with any new dependencies introduced? If so, please mention them below:

@kyleoconnell kyleoconnell merged commit bd4eed7 into dev Feb 20, 2024
1 check failed
@kyleoconnell kyleoconnell deleted the bakta_dev branch February 20, 2024 19:01
@kyleoconnell kyleoconnell restored the bakta_dev branch February 27, 2024 14:53
@kyleoconnell kyleoconnell deleted the bakta_dev branch March 6, 2024 17:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants