-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Introduce Appfs telemetry #212
Conversation
373a413
to
e3baf0d
Compare
e4ecf58
to
41c388a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #212 +/- ##
==========================================
+ Coverage 40.89% 41.12% +0.22%
==========================================
Files 102 104 +2
Lines 9659 9846 +187
Branches 1425 1438 +13
==========================================
+ Hits 3950 4049 +99
- Misses 4867 4944 +77
- Partials 842 853 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d5728cf
to
cf7e330
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no change of README / doc even though this PR adds new features.
986985e
to
bdd4d2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy for at least a short entry in the readme.
However, Pavel, if you were not a developer but some user, would you be able to read enough information from this?
What would you expect to find in doc?
I expected to find example of the mounted vfs, description of files, variables and values I can find there.
I understand it is possible to just start it and look at it (and hopefully understand everything at once), but a good documentation should be much more helpful.
bdd4d2c
to
d44905d
Compare
No description provided.