Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Introduce Appfs telemetry #212

Merged
merged 17 commits into from
Aug 16, 2024
Merged

Introduce Appfs telemetry #212

merged 17 commits into from
Aug 16, 2024

Conversation

SiskaPavel
Copy link
Contributor

No description provided.

@SiskaPavel SiskaPavel force-pushed the appfs-telemetry branch 5 times, most recently from e4ecf58 to 41c388a Compare August 14, 2024 09:09
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 42.76316% with 87 lines in your changes missing coverage. Please review.

Project coverage is 41.12%. Comparing base (f616af2) to head (d44905d).
Report is 18 commits behind head on master.

Files Patch % Lines
storage/cache.cpp 46.66% 26 Missing and 6 partials ⚠️
ipfixprobe.cpp 40.62% 17 Missing and 2 partials ⚠️
storage/fragmentationCache/fragmentationCache.cpp 22.22% 14 Missing ⚠️
input/input.cpp 47.82% 12 Missing ⚠️
input/parser.cpp 0.00% 3 Missing ⚠️
ipfixprobe.hpp 40.00% 3 Missing ⚠️
include/ipfixprobe/telemetry-utils.hpp 60.00% 1 Missing and 1 partial ⚠️
include/ipfixprobe/storage.hpp 0.00% 1 Missing ⚠️
input/raw.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
+ Coverage   40.89%   41.12%   +0.22%     
==========================================
  Files         102      104       +2     
  Lines        9659     9846     +187     
  Branches     1425     1438      +13     
==========================================
+ Hits         3950     4049      +99     
- Misses       4867     4944      +77     
- Partials      842      853      +11     
Flag Coverage Δ
tests 41.12% <42.76%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SiskaPavel SiskaPavel force-pushed the appfs-telemetry branch 3 times, most recently from d5728cf to cf7e330 Compare August 14, 2024 10:05
Copy link
Contributor

@cejkato2 cejkato2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no change of README / doc even though this PR adds new features.

input/dpdk.cpp Outdated Show resolved Hide resolved
ipfixprobe.spec.in Outdated Show resolved Hide resolved
@SiskaPavel SiskaPavel force-pushed the appfs-telemetry branch 2 times, most recently from 986985e to bdd4d2c Compare August 15, 2024 08:48
Copy link
Contributor

@cejkato2 cejkato2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy for at least a short entry in the readme.
However, Pavel, if you were not a developer but some user, would you be able to read enough information from this?

What would you expect to find in doc?

I expected to find example of the mounted vfs, description of files, variables and values I can find there.
I understand it is possible to just start it and look at it (and hopefully understand everything at once), but a good documentation should be much more helpful.

@SiskaPavel SiskaPavel merged commit bd14632 into master Aug 16, 2024
5 checks passed
@SiskaPavel SiskaPavel deleted the appfs-telemetry branch August 16, 2024 11:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants