Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

rpmbuild - add build timestamp to rpm package name #214

Closed
wants to merge 1 commit into from

Conversation

SiskaPavel
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.87%. Comparing base (f616af2) to head (1e3b7c6).
Report is 53 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
- Coverage   40.89%   40.87%   -0.03%     
==========================================
  Files         102      102              
  Lines        9659     9659              
  Branches     1425     1425              
==========================================
- Hits         3950     3948       -2     
- Misses       4867     4869       +2     
  Partials      842      842              
Flag Coverage Δ
tests 40.87% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SiskaPavel SiskaPavel requested a review from cejkato2 July 30, 2024 15:24
Copy link
Contributor

@cejkato2 cejkato2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not standard use of release.
What is your support for this change?

I see we miss %{?dist} thst is usually appended, however, "release" means number of releases of the package - as it is mentioned, e.g., here: https://rpm-packaging-guide.github.io/
or: https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/7/html-single/rpm_packaging_guide/index#setting-up-rpm-packaging-workspace_rpm-packages

Release 									

The number of times this version of the software was released. Normally, set the initial value to 1%{?dist}, and increment it with each new release of the package. Reset to 1 when a new Version of the software is built. 									

@SiskaPavel SiskaPavel closed this Sep 30, 2024
@SiskaPavel SiskaPavel deleted the rpm-timestamp branch December 16, 2024 07:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants