TLS refactor #227
Open
TLS refactor #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiskaPavel
reviewed
Nov 7, 2024
SiskaPavel
reviewed
Nov 8, 2024
Zadamsa
force-pushed
the
tls-refactor
branch
5 times, most recently
from
123d004 to
dd4966c
Compare
SiskaPavel
reviewed
Nov 25, 2024
SiskaPavel
reviewed
Nov 25, 2024
Zadamsa
force-pushed
the
tls-refactor
branch
3 times, most recently
from
388d807 to
914717f
Compare
Zadamsa
force-pushed
the
tls-refactor
branch
from
914717f to
8f44010
Compare
|
Udelej rebase + oprav buildovani a ja to nasadim na test |
SiskaPavel
reviewed
Jan 10, 2025
process/tls_parser.hpp
Outdated
| uint32_t m_packet_length{0}; | ||
|
|
||
| uint32_t m_header_section_size {0}; | ||
| constexpr static inline const uint32_t TLS_RANDOM_BYTES_LENGTH = 32; |
There was a problem hiding this comment.
Toto uz je prekombinovane
Suggested change
| constexpr static inline const uint32_t TLS_RANDOM_BYTES_LENGTH = 32; | |
| static constexpr uint32_t TLS_RANDOM_BYTES_LENGTH = 32; |
| @@ -0,0 +1,148 @@ | |||
| // Single file sha256 | |||
There was a problem hiding this comment.
Tento soubor chybi v Makefile a proto neprochazi build
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #227 +/- ##
==========================================
+ Coverage 40.78% 41.55% +0.77%
==========================================
Files 104 105 +1
Lines 10124 10307 +183
Branches 1492 1489 -3
==========================================
+ Hits 4129 4283 +154
- Misses 5130 5163 +33
+ Partials 865 861 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.