Obtain test ports from env and share code between tests #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 14, 2024 10:50
This test was previously deleted from cmake, yet the source file remained.
The code tested by these two tests is tested in many other tests, so keeping them seems redundant.
This test was previously deleted from cmake, yet the source file remained.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
michalvasko
requested changes
Aug 14, 2024
michalvasko
approved these changes
Aug 14, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the ports were set via a macro, which made a normal test and a valgrind one share the same port. This sometimes led to one of them failing when run concurrently (as in this job for example).
Now they are obtained from the environment that is generated by cmake.
This PR also includes the first step of sharing code between tests.