Rebalance Spawnpoints #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrefgtzweve
requested changes
Feb 5, 2025
wrefgtzweve
previously approved these changes
Feb 6, 2025
brandonsturgeon
requested changes
Feb 6, 2025
Comment on lines
+20
to
+39
| function CFC_SpawnPoints.IsFriendly( spawnPoint, ply ) | ||
| if not CPPI then | ||
| if spawnPoint:GetCreatingPlayer() == ply then return true end | ||
|
|
||
| return false, "You can only link to your own Spawn Points." | ||
| end | ||
|
|
||
| local owner = spawnPoint:CPPIGetOwner() | ||
| if ply == owner then return true end | ||
|
|
||
| local friends = owner.CPPIGetFriends and owner:CPPIGetFriends() | ||
|
|
||
| if not friends or friends == CPPI.CPPI_DEFER or friends == CPPI.CPPI_NOTIMPLEMENTED then | ||
| return false, "You can only link to your own Spawn Points." | ||
| end | ||
|
|
||
| if table.HasValue( friends, ply ) then return true end | ||
|
|
||
| return false, "You are not buddied with the Spawn Point's owner." | ||
| end |
There was a problem hiding this comment.
Would probably be good to have a hook in here somewhere too (squad addons or something)
There was a problem hiding this comment.
In the readme, it's noted that this function is meant to be overridden as needed, and cfc_pvp already does this. I personally think spawnpoint friendliness needs too specific of a check to make sense with hooks, but I can change it if you have a good idea on how to handle it.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does some assorted cleanup to match current CFC coding standards (and fix minor bugs), adds some audiovisual polish for player interaction, and makes the following balance changes:
sbox_maxsent_spawnpoint)cfc_spawnpoints_cooldown_on_ply_spawn)cfc_spawnpoints_cooldown_on_point_spawn)(
cfc_spawnpoints_removal_window)The goal is to make it considerably harder for someone to maintain a permanent spawn point by repeatedly creating and linking to one (or pre-spawned backups) between deaths. Now defenders must actually defeat any immediate threats before they can reclaim their spawn if it gets destroyed while they are still alive.