Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Bug: One of the Frequency Plan ID for AU915-928 is not named properly #1970

Closed
adcoly opened this issue Mar 30, 2023 · 1 comment · Fixed by #1971
Closed

Bug: One of the Frequency Plan ID for AU915-928 is not named properly #1970

adcoly opened this issue Mar 30, 2023 · 1 comment · Fixed by #1971
Assignees
@kbeaugrand
Labels
bug Something isn't working
Milestone
The Portal Keeper...

Comments

@adcoly
Copy link

adcoly commented Mar 30, 2023

At the moment, in the src/AzureIoTHub.Portal.Server/Controllers/v1.0/LoRaWAN/LoRaWANFrequencyPlansController.cs file, the last frequency plan id is named "AU_915_928_FSB_7" instead of "AU_915_928_FSB_8"
image

I also noticed something that seems strange to me in the naming region of every LBS configuration file for the same AU915-928 Frequency Plan.

For example, in this file src/AzureIoTHub.Portal.Server/RouterConfigFiles/AU_915_928_FSB_1.json (line , the Region is set to "AS923". Shouldn't it be "AU915" instead ?
@adcoly adcoly added the bug Something isn't working label Mar 30, 2023
@github-project-automation github-project-automation bot moved this to 📝 Todo in IoT Hub Portal Mar 30, 2023
@kbeaugrand
Copy link
Member

You're right @adcoly thanks for this issue.
I'll fix it as soon as possible in the next release.

@kbeaugrand kbeaugrand self-assigned this Mar 30, 2023
@kbeaugrand kbeaugrand added this to the The Portal Keepers - S55 milestone Mar 30, 2023
kbeaugrand added a commit that referenced this issue Mar 30, 2023
@kbeaugrand
Fix #1970 - Remove duplicated Frequency plan id for AU_915_928_FSB_8
626237c
@hocinehacherouf hocinehacherouf mentioned this issue Mar 30, 2023
Merged
9 tasks
kbeaugrand added a commit that referenced this issue Mar 30, 2023
@kbeaugrand
Fix #1970 - Remove duplicated Frequency plan id for AU_915_928_FSB_8 (#…
ef9dbbd 
…1971)
@hocinehacherouf hocinehacherouf moved this from 📝 Todo to 🚀 Ready in IoT Hub Portal Mar 31, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@kbeaugrand kbeaugrand

Labels
bug Something isn't working
Projects
IoT Hub Portal
Status: 🚀 Ready
Milestone
The Portal Keepers - S55
Development

Successfully merging a pull request may close this issue.

Fix #1970 - Remove duplicated Frequency plan id for AU_915_928_FSB_8 CGI-FR/IoT-Hub-Portal
2 participants
@kbeaugrand @adcoly