Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

PLT-596: Resolve dependabot PR on aws-params-env-action #138

Conversation

christopher-maboh
Copy link
Contributor

@christopher-maboh christopher-maboh commented Oct 28, 2024

🎫 Ticket

PLT-596

🛠 Changes

dist directory was deleted with rm -rf dist/ locally and the dist/ directory was rebuilt using npm ci # Install dependencies
npm run build # Build the project
npm run package # Package the project

ℹ️ Context

We have a new dependabot security PR on aws-params-env-action at #108. Update the dist/ and ensure tests pass before approving and merging.

🧪 Validation

After dist was rebuilt locally and pushed, Check dist/ for aws-params-env-action / check-dist (pull_request) test that previously failed at Compare the expected and actual dist/ directories ran successfully.
all checks now run successfully and can be seen in this PR below

@christopher-maboh christopher-maboh requested a review from a team as a code owner October 28, 2024 21:14
@christopher-maboh christopher-maboh changed the base branch from main to dependabot/npm_and_yarn/actions/aws-params-env-action/npm_and_yarn-50e9927b4d October 28, 2024 21:41
Copy link
Contributor

@ildesenesence ildesenesence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Passing tests and [mostly] the same changes appear to resolve the dependabot PR. Appreciate the comprehensive notes.

@christopher-maboh christopher-maboh merged commit fa50e75 into dependabot/npm_and_yarn/actions/aws-params-env-action/npm_and_yarn-50e9927b4d Oct 29, 2024
4 checks passed
@christopher-maboh christopher-maboh deleted the PLT-596 branch October 29, 2024 16:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants