Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

PLT-832: Update upload-artifacts from v3 to v4 #158

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gfreeman-navapbc
Copy link
Contributor

🎫 Ticket

https://jira.cms.gov/browse/PLT-832

🛠 Changes

Changed upload-artifacts version to v4.

ℹ️ Context

The current upload-artifacts version is being sunset, so we will have to update the version to v4.

🧪 Validation

Workflow should run without failures

@gfreeman-navapbc gfreeman-navapbc requested a review from a team as a code owner January 2, 2025 19:33
@gfreeman-navapbc gfreeman-navapbc self-assigned this Jan 2, 2025
Copy link
Member

@gsf gsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You could temporarily (or permanently) add .github/workflows/aws-params-env-action-check-dist.yml to the paths in the pull_request trigger of this workflow to check it in this PR.

@gfreeman-navapbc
Copy link
Contributor Author

Looks good. You could temporarily (or permanently) add .github/workflows/aws-params-env-action-check-dist.yml to the paths in the pull_request trigger of this workflow to check it in this PR.

@gsf looks like it succeeds, but the workflow doesn't actually run the upload since the diff doesn't produce anything.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants