PLT-832: Update upload-artifacts from v3 to v4 #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsf
reviewed
Jan 2, 2025
@gsf looks like it succeeds, but the workflow doesn't actually run the upload since the diff doesn't produce anything. |
gsf
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
We could go so far as to comment out the "if" clause but seeing as we're not getting into multiple artifacts or hidden files as mentioned in the migration notes, I think this is good to go.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/PLT-832
🛠 Changes
Changed upload-artifacts version to v4.
ℹ️ Context
The current upload-artifacts version is being sunset, so we will have to update the version to v4.
🧪 Validation
Workflow should run without failures