BCDA-8680: Refactor to allow for ipv6 addresses #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlpartridge
commented
Jan 22, 2025
| assert.Nil(t, err) | ||
| defer conn.Close(ctx) | ||
|
|
||
| tx, err := conn.Begin(context.Background()) |
There was a problem hiding this comment.
Slight refactoring of this test to use transaction to avoid data issues.
carlpartridge
commented
Jan 22, 2025
| } else { | ||
| lambda.Start(handler) | ||
| } | ||
| lambda.Start(handler) |
There was a problem hiding this comment.
Refactored away from needing isTesting, I dont think we got a lot out of it?
|
Integration test is currently failing I believe due to the new IPv6 IP set not existing yet, see: CMSgov/ab2d-bcda-dpc-platform#165 |
bhagatparwinder
approved these changes
Jan 22, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/BCDA-8680
🛠 Changes
Refactor to allow for IPv6 addresses. Some refactoring in other places to clean things up a bit.
ℹ️ Context
Previously this lambda was erroring out on trying to add IPv6 addresses into the existing IP set. Turns out IP sets only allow for one type of IP. CDAP has created a secondary IP set for IPv6 addresses. The code has been refactored to allow for updating of both kinds.
🧪 Validation
Local testing and linting.