[WNMGDS-3182] Updates two @testing-library dependencies
#3458
+1,343
−1,320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ary/react-hooks` dep
…@testing-library/react`
…` and uses jest's modern fakeTimers
…ecause v14 of `@testing-library/user-event` only passes along `key`
kim-cmsds
added
Type: Internal
| @@ -6,8 +6,7 @@ const usePreact = Boolean(JSON.parse(process.env.PREACT ?? 'true')); | |||
| const preactAliases = usePreact | |||
| ? { | |||
| react: 'preact/compat', | |||
| 'react-dom/test-utils': 'preact/test-utils', | |||
There was a problem hiding this comment.
Wait, why did these go away?
| @@ -121,11 +124,11 @@ describe('SingleInputDateField', function () { | |||
| // https://github.com/testing-library/dom-testing-library/issues/774#issuecomment-702574312 | |||
| // but it isn't working | |||
| // | |||
| // it('selecting a day calls onChange', () => { | |||
| // it('selecting a day calls onChange', async () => { | |||
There was a problem hiding this comment.
This test doesn't work even with the new version updates?
| @@ -24,6 +27,11 @@ function expectInvalid(textField: HTMLElement) { | |||
| } | |||
|
|
|||
| describe('DateInput', () => { | |||
| afterEach(() => { | |||
There was a problem hiding this comment.
We need this clean up for anytime we use fakeTimers, right? I think there are two tests that use fake timers but don't do this clean up. Is that ok?
There was a problem hiding this comment.
Seems like its: ChoiceList, ds-choice-list and IdleTimeout. Do those tests not need the cleanup for some reason?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@testing-library/preact,@testing-library/react, and@testing-library/user-eventand removes@testing-library/preact-hooksand@testing-library/react-hooks.userEvent.clickis now a promise that needs to be awaited and the docs recommend invoking a single session that more closely replicates user behaviorHow to test
npm installnpm run test:unit,npm run test:unit:wc, andnpm run test:unit:preactmainand another is a new issue with theuseClickOutsideHandler.test.tsxtest. I do not propose either should block this work but open to feedback.Checklist
[WNMGDS-####] Titleor [NO-TICKET] if this is unticketed work.Type(only one) label for this PR, if it is a breaking change, label should only beType: BreakingImpacts, multiple can be selected.If this is a change to code:
npm run test:unitandnpm run test:browser:allwere each successfulnpm run test:unit:update) and browser-test snapshots (npm run test:browser:all:update)