Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Lint error in WebView #48

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Conversation

Lee245
Copy link
Contributor

@Lee245 Lee245 commented Feb 27, 2024

Pipeline failed because of lint:
/home/runner/work/NLWeer/NLWeer/app/src/main/res/layout/fragment_knmi_sixdayforecast.xml:19: Error: Placing a <WebView> in a parent element that uses a wrap_content layout_height can lead to subtle bugs; use match_parent instead [WebViewLayout]

This should fix it

Copy link
Owner

@CNugteren CNugteren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing. I checked and the new forecast still looks like before, and I also verified that Gradle now indeed reports no linter errors.

@CNugteren CNugteren merged commit 6c49961 into CNugteren:master Feb 28, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants