Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update README.md re. vgrid #34

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Update README.md re. vgrid #34

merged 2 commits into from
Sep 16, 2024

Conversation

aekiss
Copy link
Contributor

@aekiss aekiss commented Jul 24, 2024

See #33

@aekiss aekiss requested a review from micaeljtoliveira July 24, 2024 04:32
@micaeljtoliveira
Copy link
Contributor

@aekiss It should be easy to add an assertion in the Fortran code to check if the number of values is odd, as that should always be the case for MOM5 vgrids (2n+1 values for n levels). It wouldn't complain about MOM6 vgrids where n+1 is odd, but it's better than nothing... What do you think?

@aekiss
Copy link
Contributor Author

aekiss commented Jul 25, 2024

Yep, might as well, but with a comment to explain it will only catch this problem half the time.
It won't help with the 51 vs 101 case we discussed yesterday, but would catch 76 vs 151 which will be the new default at all resolutions.

@micaeljtoliveira
Copy link
Contributor

Merging this. Will implement the assertion in the Fortran code in a separate MR.

@micaeljtoliveira micaeljtoliveira merged commit aea17bf into master Sep 16, 2024
4 checks passed
@micaeljtoliveira micaeljtoliveira deleted the iss33 branch September 18, 2024 22:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants