Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove value/default inconsistency #200

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

danielwilms
Copy link
Collaborator

In the spec value and default were used exchangeably.
Used default throughout the spec-files.

Fixes: #198

In the spec value and default were used exchangeably.
Used `default` throughout the spec-files.

Fixes: COVESA#198
@danielwilms danielwilms added this to the vss2 milestone Oct 13, 2020
Copy link
Collaborator

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me

@danielwilms
Copy link
Collaborator Author

Discussion if functionality is needed

Copy link
Collaborator

@adobekan adobekan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with default.

@SebastianSchildt
Copy link
Collaborator

No strong of opinion as long is it consistent.

My personal opinion however is, that neither "default" or "value" needs to be specified in VSS (just look at the current defaults), as this is a deployment question.

Copy link

@Issalena2k23 Issalena2k23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs-gen/content/rule_set/data_entry/attributes.md

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency with attribute value vs. default
5 participants