Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[!!!][FEATURE] Add support for different languages #2

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

eliashaeussler
Copy link
Member

This PR adds language support for positions fetched from Personio API.

@eliashaeussler eliashaeussler added the enhancement New feature or request label Mar 13, 2023
@eliashaeussler eliashaeussler self-assigned this Mar 13, 2023
@eliashaeussler eliashaeussler changed the base branch from task/init to develop March 20, 2023 08:23
@eliashaeussler eliashaeussler force-pushed the develop branch 2 times, most recently from 27ed084 to b262f2f Compare March 20, 2023 12:54
@eliashaeussler eliashaeussler force-pushed the feature/language-support branch from 38f1342 to 36fdb0e Compare March 20, 2023 17:09
@codeclimate
Copy link

codeclimate bot commented Mar 20, 2023

Code Climate has analyzed commit 0acc6cb and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 17.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 4.3% (0.6% change).

View more on Code Climate.

@eliashaeussler eliashaeussler changed the title Draft: [FEATURE] Add support for different languages [FEATURE] Add support for different languages Mar 20, 2023
@eliashaeussler eliashaeussler marked this pull request as draft March 20, 2023 17:10
@eliashaeussler eliashaeussler force-pushed the feature/language-support branch 2 times, most recently from be2c85b to 51e7be6 Compare March 20, 2023 18:10
@ina-beckmann
Copy link

Are there any plans to implement this in the main branch? We would love to use this for a multilanguage page.

@eliashaeussler
Copy link
Member Author

Are there any plans to implement this in the main branch? We would love to use this for a multilanguage page.

@ina-beckmann We still plan to implement this feature. Unfortunately, it's not complete yet and I did not have the time for further implementations. I hope to finish and release it soon.

@eliashaeussler eliashaeussler changed the base branch from develop to main January 3, 2024 15:27
@eliashaeussler eliashaeussler force-pushed the feature/language-support branch from 51e7be6 to db235e7 Compare January 3, 2024 16:05
@eliashaeussler eliashaeussler changed the title [FEATURE] Add support for different languages [!!!][FEATURE] Add support for different languages Jan 5, 2024
@eliashaeussler eliashaeussler added the breaking This introduces a breaking change label Jan 5, 2024
@eliashaeussler eliashaeussler force-pushed the feature/language-support branch from db235e7 to 56865f2 Compare January 5, 2024 15:23
@eliashaeussler eliashaeussler force-pushed the feature/language-support branch from 56865f2 to 47fe2eb Compare January 8, 2024 19:26
@CPS-IT CPS-IT deleted a comment from codecov bot Jan 30, 2025
@coveralls
Copy link
Collaborator

coveralls commented Jan 30, 2025

Pull Request Test Coverage Report for Build 13047589007

Details

  • 9 of 52 (17.31%) changed or added relevant lines in 7 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.7%) to 4.304%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Classes/Event/AfterJobsMappedEvent.php 0 2 0.0%
Classes/Domain/Model/Job.php 0 3 0.0%
Classes/Command/ImportCommand.php 0 8 0.0%
Classes/Domain/Repository/JobRepository.php 0 12 0.0%
Classes/Service/PersonioImportService.php 0 18 0.0%
Files with Coverage Reduction New Missed Lines %
Classes/Event/AfterJobsMappedEvent.php 1 0.0%
Classes/Domain/Repository/JobRepository.php 1 0.0%
Totals Coverage Status
Change from base Build 12746587670: 0.7%
Covered Lines: 34
Relevant Lines: 790

💛 - Coveralls

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
breaking This introduces a breaking change enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants