Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove a couple of deprecation warnings from the tests #448

Merged
merged 4 commits into from
Jan 17, 2025
Merged

Remove a couple of deprecation warnings from the tests #448

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0cd3e8
Use n_local instead of TwoLocal.
cqc-alec Jan 15, 2025
bc4cc34
Use real_amplitudes instead of RealAmplitudes and fix test.
cqc-alec Jan 15, 2025
b608678
Order imports.
cqc-alec Jan 17, 2025
13b577f
Merge branch 'main' into ae/deprec
cqc-alec Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions tests/qiskit_convert_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@
from qiskit.circuit.library import (
MCMTGate,
PauliEvolutionGate,
RealAmplitudes,
RYGate,
TwoLocal,
UnitaryGate,
XXPlusYYGate,
n_local,
real_amplitudes,
)
from qiskit.circuit.parameterexpression import ParameterExpression # type: ignore
from qiskit.quantum_info import Operator, SparsePauliOp, Statevector # type: ignore
Expand Down Expand Up @@ -1124,22 +1124,17 @@ def test_failed_conversion_error() -> None:


# https://github.com/CQCL/pytket-qiskit/issues/200
def test_RealAmplitudes_numeric_params() -> None:
def test_real_amplitudes_numeric_params() -> None:
qc = QuantumCircuit(3)
params = [np.pi / 2] * 9
real_amps1 = RealAmplitudes(3, reps=2)
real_amps1 = real_amplitudes(3, reps=2)
real_amps2 = real_amps1.assign_parameters(params)
qc.compose(real_amps2, qubits=[0, 1, 2], inplace=True)
# Unitary operator of the qiskit circuit. Order reversed from little -> big endian.
# The reversal means we can check it for equivalence with a tket unitary
qiskit_unitary = Operator(qc.reverse_bits()).data
converted_tkc = qiskit_to_tk(qc)
assert converted_tkc.n_gates == 1
assert converted_tkc.n_gates_of_type(OpType.CircBox) == 1
circbox_op = converted_tkc.get_commands()[0].op
assert isinstance(circbox_op, CircBox)
assert circbox_op.get_circuit().name == "RealAmplitudes"
DecomposeBoxes().apply(converted_tkc)
assert converted_tkc.n_gates == 13
assert converted_tkc.n_gates_of_type(OpType.CX) == 4
assert converted_tkc.n_gates_of_type(OpType.Ry) == 9
unitary1 = converted_tkc.get_unitary()
Expand All @@ -1152,7 +1147,7 @@ def test_RealAmplitudes_numeric_params() -> None:

# https://github.com/CQCL/pytket-qiskit/issues/256
def test_symbolic_param_conv() -> None:
qc = TwoLocal(1, "ry", "cz", reps=1, entanglement="linear")
qc = n_local(2, "ry", "cz", reps=1, entanglement="linear")
qc_transpiled = transpile(
qc, basis_gates=["sx", "rz", "cx", "x"], optimization_level=3
)
Expand Down
Loading