Skip to content
This repository has been archived by the owner on May 20, 2023. It is now read-only.

UI: add new css WhiteTheme.css #144

Merged
merged 1 commit into from
Apr 1, 2019

Conversation

lycjackie
Copy link

@lycjackie lycjackie commented Mar 31, 2019

The black theme was created for AddressBook, as our application have
morph from AddressBook to PlanWithEase, we should have our own
style to allow our users to remember our product.

Let's overhaul the UI and give our application a new look and:

  • display module name in degree planner
  • display total credits in degree planner
  • cascade all changes needed to allow our application to look nicer.

Screenshot of our application as shown below.

image

@lycjackie lycjackie added the aspect.UIX User Interface, User experience, responsiveness label Mar 31, 2019
@lycjackie lycjackie added this to the v1.3 milestone Mar 31, 2019
@lycjackie lycjackie requested a review from Letm3through March 31, 2019 11:43
@lycjackie lycjackie added the status.ToReview Pull requests to be reviewed label Mar 31, 2019
@coveralls
Copy link

coveralls commented Mar 31, 2019

Coverage Status

Coverage increased (+0.06%) to 87.306% when pulling 0a6fbf3 on lycjackie:ui-experiment into c1493f2 on CS2113-AY1819S2-T09-1:master.

@lycjackie lycjackie force-pushed the ui-experiment branch 2 times, most recently from 2df467e to ccc5695 Compare March 31, 2019 11:55
@Creastery Creastery added status.Ongoing The issue/PR is currently being worked on. note: remove this label before closing an issue/PR and removed status.ToReview Pull requests to be reviewed labels Mar 31, 2019
@Creastery
Copy link

@lycjackie Will need you to rebase and make the necessary changes to color scheme again after PR #133 is merged.

@lycjackie
Copy link
Author

@lycjackie Will need you to rebase and make the necessary changes to color scheme again after PR #133 is merged.

Alright sure will do! 👍

@lycjackie lycjackie force-pushed the ui-experiment branch 3 times, most recently from 0408eec to 37088ba Compare March 31, 2019 20:23
@lycjackie lycjackie added status.ToReview Pull requests to be reviewed and removed status.Ongoing The issue/PR is currently being worked on. note: remove this label before closing an issue/PR labels Mar 31, 2019
The black theme was created for `AddressBook`, as our application have
morph from `AddressBook` to `PlanWithEase`, we should have our own
style to allow our users to remember our product.

Let's update the CSS to have some contrasts from the original
`AddressBook` and:
- cascade all changes needed to allow our application to look nicer.
- display module name in degree planner
- display total credits in degree planner
Copy link

@Letm3through Letm3through left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for updating to make our UI amazing.
Approving and merging.

@Letm3through Letm3through merged commit da90b9c into CS2113-AY1819S2-T09-1:master Apr 1, 2019
@Creastery Creastery added type.Task Something that needs to be done, but not a story, bug, or an epic and removed status.ToReview Pull requests to be reviewed labels Apr 1, 2019
@lycjackie lycjackie deleted the ui-experiment branch April 1, 2019 09:24
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
aspect.UIX User Interface, User experience, responsiveness type.Task Something that needs to be done, but not a story, bug, or an epic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants