This repository has been archived by the owner on May 20, 2023. It is now read-only.
forked from nusCS2113-AY1819S2/addressbook-level4
-
Notifications
You must be signed in to change notification settings - Fork 4
UI: add new css WhiteTheme.css
#144
Merged
Letm3through
merged 1 commit into
CS2113-AY1819S2-T09-1:master
from
lycjackie:ui-experiment
Apr 1, 2019
Merged
UI: add new css WhiteTheme.css
#144
Letm3through
merged 1 commit into
CS2113-AY1819S2-T09-1:master
from
lycjackie:ui-experiment
Apr 1, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lycjackie
force-pushed
the
ui-experiment
branch
2 times, most recently
from
March 31, 2019 11:55
2df467e
to
ccc5695
Compare
Creastery
added
status.Ongoing
The issue/PR is currently being worked on. note: remove this label before closing an issue/PR
and removed
status.ToReview
Pull requests to be reviewed
labels
Mar 31, 2019
@lycjackie Will need you to rebase and make the necessary changes to color scheme again after PR #133 is merged. |
Alright sure will do! 👍 |
lycjackie
force-pushed
the
ui-experiment
branch
3 times, most recently
from
March 31, 2019 20:23
0408eec
to
37088ba
Compare
lycjackie
added
status.ToReview
Pull requests to be reviewed
and removed
status.Ongoing
The issue/PR is currently being worked on. note: remove this label before closing an issue/PR
labels
Mar 31, 2019
lycjackie
force-pushed
the
ui-experiment
branch
from
March 31, 2019 20:32
37088ba
to
0d95ec8
Compare
The black theme was created for `AddressBook`, as our application have morph from `AddressBook` to `PlanWithEase`, we should have our own style to allow our users to remember our product. Let's update the CSS to have some contrasts from the original `AddressBook` and: - cascade all changes needed to allow our application to look nicer. - display module name in degree planner - display total credits in degree planner
lycjackie
force-pushed
the
ui-experiment
branch
from
March 31, 2019 20:35
0d95ec8
to
0a6fbf3
Compare
Letm3through
approved these changes
Apr 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for updating to make our UI amazing.
Approving and merging.
Creastery
added
type.Task
Something that needs to be done, but not a story, bug, or an epic
and removed
status.ToReview
Pull requests to be reviewed
labels
Apr 1, 2019
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Labels
aspect.UIX
User Interface, User experience, responsiveness
type.Task
Something that needs to be done, but not a story, bug, or an epic
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The black theme was created for
AddressBook
, as our application havemorph from
AddressBook
toPlanWithEase
, we should have our ownstyle to allow our users to remember our product.
Let's overhaul the UI and give our application a new look and:
Screenshot of our application as shown below.