Skip to content

extend _findFromPoint to support Vertex #1853

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

adam-urbanczyk
Copy link
Member

Fixes #1845

@adam-urbanczyk adam-urbanczyk marked this pull request as draft June 3, 2025 05:37
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.66%. Comparing base (f754469) to head (5bac2a1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cadquery/cq.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1853   +/-   ##
=======================================
  Coverage   95.66%   95.66%           
=======================================
  Files          28       28           
  Lines        7431     7433    +2     
  Branches     1122     1123    +1     
=======================================
+ Hits         7109     7111    +2     
  Misses        193      193           
  Partials      129      129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jmwright
Copy link
Member

jmwright commented Jun 4, 2025

@adam-urbanczyk Do you want to try to include this PR in the June release too?

@adam-urbanczyk
Copy link
Member Author

I think so. I'll just add a test and it should be good to go.

@adam-urbanczyk adam-urbanczyk marked this pull request as ready for review June 6, 2025 17:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot draw a line from a selected vertex
2 participants