Remove the default download timeout of 5 minutes for a single file #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #81 +/- ##
=======================================
Coverage 89.64% 89.64%
=======================================
Files 4 4
Lines 425 425
=======================================
Hits 381 381
Misses 44 44
Continue to review full report at Codecov.
|
Also close the request which gets the headers before opening new ones when transferring data.
dstansby
approved these changes
Dec 15, 2021
|
Maybe closing the original request will solve #65 ?? |
|
We can but hope that it helps 65. It should close the connection eventually i.e. when the whole file has transferred anyway. |
Cadair
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also close the request which gets the headers before opening new ones when transferring data.