Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Patch for sprites not being marked as active when used in a SpriteCoordinateExpander #2616

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

MCRcortex
Copy link
Contributor

Fix for #2601 class of issues, however it assumes that a new SpriteCoordinateExpander is created every frame. Marking it as active in the hot path every write might have performance implications, thus only a partial fix.

…hat a new SpriteCoordinateExpander is created every frame.
@jellysquid3
Copy link
Member

I'm not really sure this is robust enough. At least, if you create a VertexBuffer from a BufferBuilder, and render that, it won't track the sprites. Can we perhaps put something into BufferBuilder.BuiltBuffer to track the sprites and have them be updated each time the buffer is rendered?

@jellysquid3 jellysquid3 added this to the Sodium 0.6.1 milestone Aug 13, 2024
@jellysquid3 jellysquid3 modified the milestones: Sodium 0.6.1, Sodium 0.6.2 Dec 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants