A proposal on additional batteries: adding "type" info. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main idea is to differentiate 9-Volts from D-cells. Introduce a new integer for battery types. This is then used in battery-type queries. Note: This is a very rough fix, so no guarantees. Variables will likely need to change names. Extension methods also change accordingly.
As vanilla batteries are used more often.
In case of only looking for specific battery sets, these can be useful. Also minor change to code.
PeterRed4091
changed the title
|
Note this proposal need further discussions, and may change in time. |
|
As this could possibly be against the original purposes, I might as well close it after such a long time. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a value for battery types into query response.
Include changes to bomb info extension methods.