Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

Migrate to Python 3.7 #21

Merged
merged 37 commits into from
Jan 2, 2020
Merged

Migrate to Python 3.7 #21

merged 37 commits into from
Jan 2, 2020

Conversation

dvvanessastoiber
Copy link
Contributor

@dvvanessastoiber dvvanessastoiber commented Dec 13, 2019

Required PR phovea/phovea_server#89

Changes according to wiki page

Summary

  • Use new Python 3.7 syntax and adapt import statements accordingly
  • Use adequate Docker and CircleCi images
  • Update requirements.txt and requirements_dev.txt
  • Remove .gitlab-ci.yml

thinkh and others added 30 commits August 19, 2019 14:06
Due native integration in Python 3
created .circleci folder and config.yml
done for .travis.yml and tox.ini in taco_server
avoid default usage of numpy types
- changed dtype of numpy.ndarray to string
- ensure that index 'i' can be found in array
('disordered' can eventually be an encapsulated array)
- remove underscore
- change type of ndarray
and remove environment variable (no frontend-only repo)
# Conflicts:
#	.circleci/config.yml
@dvvanessastoiber dvvanessastoiber added the type: refactor Refactor the current implementation label Dec 13, 2019
@dvvanessastoiber dvvanessastoiber requested review from thinkh and a user December 13, 2019 06:06
@dvvanessastoiber dvvanessastoiber assigned thinkh and ghost Dec 13, 2019
@ghost ghost removed their request for review December 16, 2019 06:35
@ghost ghost removed their assignment Dec 16, 2019
@thinkh thinkh added the release: major PR merge results in a new major version label Jan 2, 2020
@thinkh thinkh marked this pull request as ready for review January 2, 2020 13:24
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work. Looks good! 👍

@thinkh thinkh merged commit 005df32 into develop Jan 2, 2020
@thinkh thinkh deleted the python_3.7 branch January 2, 2020 13:31
@thinkh thinkh mentioned this pull request Jan 16, 2020
28 tasks
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
release: major PR merge results in a new major version type: refactor Refactor the current implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants