fix typo #46
Closed
fix typo #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will be fixed in newer versions. Thank you for catching this 👍 |
|
no problem :) |
Callidon
pushed a commit
that referenced
this pull request
Feb 18, 2022
Author: Arnausd Grall (@folkvir) * update deps and add gts * h64 only + fix #43 + gts * mocha: parallel execution * utils: rename *Indices to *Indexes, add better documentation * tests: show difference when using getDistinctIndexes w/wo hashing at each iteration * utils: rename *Indices to *Indexes * update ref pdf of CMS * double hashing: use the enhanced technique * getDistinctIndexes: implement #43 suggestions + allow to switch to XXH 32/64 if needed * update changelog * add .DS_Store in the list of ignored files * use typescript 4.X.X * fix typo of #46 * fix error when setting 32/64 bits xxh functions, and allow for overriding the serialize function (#48) * add code coverage * lint * update eslint ignore for faster parsing * add branch update_outdated to the tested branches * fix wrong github workflow branch name * workflow: use 16.x and remove 10.x * update README and remove useless deps * tests: fix error with describe/it rules overriding data * implemnting xor filter for the next release * update all files to the new project standard, set v2.0.0 * xor filters are working * testing the xor filter * xor filter #29 * #29 * documentation * code ql / tests on develop * keywords * fix workflow * move all hash related functions to the BaseFilter class * modify tests according to: 12417e7 * parallel mocha tests * use lts/* with setup-node@v2 * update README.md * add badge to the readme * export BaseFilter in the entry * badge refers to the last action build * update compatibility readme * update @types/node version to be the latest minor release * prettier auto line endings * update @types/node version to be the latest minor release * #49 add compatibility with 1.3.4 * #49 compatibility for BloomFilters import only is working * Use AutoExportable feature for simplfying the export process, bitsets size set to a multiple of bitwords * create Hashing classes * remove nyc, use eslint + prettier instead of gts, enforce type checking, make all propeties public, no readonly * update yarn.lock * ci: remove node 15 * fix missing dependency and fix eslint errors * update readme * fix conflicts with master, eslint is now a rule * add typedoc-plugin-missing-exports and fix non-overrided doubleHashing function
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.