Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: remove deprecated lodash per-method packages for vulnerability fixes #78

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

EmilianoSanchez
Copy link
Contributor

@EmilianoSanchez EmilianoSanchez commented Nov 12, 2024

@folkvir
Copy link
Collaborator

folkvir commented Nov 12, 2024

It would be very appreciated if you could submit your PR into #76 for the major update.
Also there are other involved lodash packages for the tests, if you could also update them 👍

@EmilianoSanchez EmilianoSanchez changed the base branch from master to bug/fixes November 12, 2024 18:24
@EmilianoSanchez EmilianoSanchez marked this pull request as draft November 12, 2024 18:24
@EmilianoSanchez EmilianoSanchez marked this pull request as ready for review November 12, 2024 18:47
@EmilianoSanchez
Copy link
Contributor Author

EmilianoSanchez commented Nov 12, 2024

Thanks @folkvir. I did the changes using direct imports (e.g., import eq from 'lodash/eq').
Another option was to use top-level imports (e.g., import {eq} from 'lodash'), although I think the former is better for tree-shaking, according to https://lodash.com/per-method-packages.

@folkvir folkvir self-requested a review November 12, 2024 20:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants