Routes being recreated on hotreload #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tes everytime the application is hot-reloaded or on log-in/log-out.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed logic to solve the error described in issue #97.
As in every, log-in/log-out the Core component and "below" was recreated including the Resource which registers the routes on the vue-router and store, and binds the components.
So the first problem was to control the registering in Resource in case the routes and bindings already were registered.
It is really important to notice that the store and the added routes to the router were not being recreated on hotreload or log-in/log-out.
Then the UI component manages the drawer items depending in a subscription for the addRoute mutation and not checking if the triggering mutation containing the "new" routes was already added.