Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

List Component: Adds the ability to navigate on row click #170

Merged
merged 3 commits into from
Oct 8, 2019
Merged

List Component: Adds the ability to navigate on row click #170

merged 3 commits into from
Oct 8, 2019

Conversation

DanielOrmeno
Copy link
Contributor

  • Adds the ability to navigate on row click
  • Stops click event propagation on EditButton and Delete Button

@DanielOrmeno DanielOrmeno mentioned this pull request Oct 6, 2019
Closed
2 tasks
@sgobotta
Copy link
Member

sgobotta commented Oct 6, 2019

Hello, thanks for the contribution. Please add a reference to the issue.

@sgobotta sgobotta self-requested a review October 6, 2019 23:14
@sgobotta sgobotta self-assigned this Oct 6, 2019
@sgobotta
Copy link
Member

sgobotta commented Oct 6, 2019

You can check which files to fix by running: npm run lint locally. The demo files shouldn't break the linter.

@DanielOrmeno
Copy link
Contributor Author

Done!

@sgobotta
Copy link
Member

sgobotta commented Oct 8, 2019

Thanks you @DanielOrmeno !

Closes #121

@sgobotta sgobotta merged commit 528896c into Cambalab:develop Oct 8, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sgobotta sgobotta Awaiting requested review from sgobotta

Assignees

@sgobotta sgobotta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielOrmeno @sgobotta