Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Uses "Vue-Admin" as project name across Readme #195

Merged
merged 3 commits into from
Jan 30, 2020

Conversation

tehuel
Copy link
Contributor

@tehuel tehuel commented Jan 28, 2020

Description

Small changes in README file to use Vue-Admin as project name.

I've decided to use this format just because of all the variations found in the README this one was the most used.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce the cases. Please also list any relevant details for your test configuration

Checklist:

The following options in bold are required for a PR approval. Please check the boxes only if necessary, it help us minimizing the reviewing process.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

sgobotta and others added 2 commits November 17, 2019 15:58
Uses the same project name across README file.
@sgobotta sgobotta self-requested a review January 29, 2020 04:09
@sgobotta
Copy link
Member

Thanks @tehuel 👌 I'm up to all those ideas that help the library improve it's readability. I just left a little text addition request, let me know what you think before merging.

@sgobotta sgobotta merged commit 637bdca into Cambalab:develop Jan 30, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants