Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

200 as a user i want to provide my own subscriptions to the resource alert system #206

Conversation

sgobotta
Copy link
Member

@sgobotta sgobotta commented Feb 8, 2020

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

This PR provides:

  • Support for adding snackbar hooks during Resource operations
  • Documentation update for the Resource component

Closes #200

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

The following options in bold are required for a PR approval. Please check the boxes only if necessary, it help us minimizing the reviewing process.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@sgobotta sgobotta added the enhancement New feature or request label Feb 8, 2020
@codecov-io
Copy link

codecov-io commented Feb 8, 2020

Codecov Report

❗ No coverage uploaded for pull request base (develop@aabf8ff). Click here to learn what that means.
The diff coverage is 19.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #206   +/-   ##
==========================================
  Coverage           ?   40.15%           
==========================================
  Files              ?       96           
  Lines              ?      787           
  Branches           ?       30           
==========================================
  Hits               ?      316           
  Misses             ?      468           
  Partials           ?        3
Impacted Files Coverage Δ
src/constants/ui.content.default.js 50% <ø> (ø)
src/store/modules/crud.js 62.5% <ø> (ø)
src/plugins/vuex/subscriptions.js 100% <ø> (ø)
src/components/Resource/src/Resource.vue 95.23% <ø> (ø)
src/components/Admin/src/Alerts.vue 100% <ø> (ø)
src/templates/src/index.js 100% <ø> (ø)
src/main.js 0% <0%> (ø)
src/components/Resource/src/defaults.js 44.44% <20%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aabf8ff...783f083. Read the comment docs.

@sgobotta sgobotta merged commit ae33869 into develop Feb 8, 2020
@sgobotta sgobotta deleted the 200-As-a-user-I-want-to-provide-my-own-subscriptions-to-the-Resource-Alert-system branch February 8, 2020 14:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants