Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

213 improve unit tests sidebar component #214

Merged
merged 15 commits into from
Feb 14, 2020

Conversation

sgobotta
Copy link
Member

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

This PR provides:

  • Unit test cases for the Sidebar component
  • Small props refactor to defaults
  • Rename DefaultSidebar to SimpleSidebar
  • Adds unit tests for the HomeLayout
  • Adds unit tests for the AppLayout
  • Adds unit tests for the Core component

Closes #213

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

The following options in bold are required for a PR approval. Please check the boxes only if necessary, it help us minimizing the reviewing process.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@sgobotta sgobotta added the enhancement New feature or request label Feb 14, 2020
@codecov-io
Copy link

codecov-io commented Feb 14, 2020

Codecov Report

Merging #214 into develop will increase coverage by 5.63%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #214      +/-   ##
===========================================
+ Coverage     46.8%   52.43%   +5.63%     
===========================================
  Files           94       94              
  Lines          750      759       +9     
  Branches        30       29       -1     
===========================================
+ Hits           351      398      +47     
+ Misses         397      359      -38     
  Partials         2        2
Impacted Files Coverage Δ
src/components/Core/src/Core.vue 100% <ø> (+100%) ⬆️
src/components/UiComponents/Sidebar/defaults.js 100% <100%> (+30%) ⬆️
src/components/Admin/src/defaults.js 100% <100%> (ø) ⬆️
.../components/UiComponents/Sidebar/SimpleSidebar.vue 100% <100%> (ø)
...components/UiComponents/Sidebar/SidebarHeading.vue 100% <100%> (+66.66%) ⬆️
src/va-auth/src/store/modules/actions.js 69.23% <0%> (+7.69%) ⬆️
src/constants/ui.element.names.js 8.33% <0%> (+8.33%) ⬆️
src/va-auth/src/store/modules/mutations.js 79.16% <0%> (+12.5%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eec08d2...a2d8ccf. Read the comment docs.

@sgobotta sgobotta merged commit 8aaf94b into develop Feb 14, 2020
@sgobotta sgobotta deleted the 213-Improve-unit-tests-Sidebar-component branch February 14, 2020 22:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants