-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
213 improve unit tests sidebar component #214
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o be reused for unit testing
+ Admin: updates SimpleSidebar import
Codecov Report
@@ Coverage Diff @@
## develop #214 +/- ##
===========================================
+ Coverage 46.8% 52.43% +5.63%
===========================================
Files 94 94
Lines 750 759 +9
Branches 30 29 -1
===========================================
+ Hits 351 398 +47
+ Misses 397 359 -38
Partials 2 2
Continue to review full report at Codecov.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
This PR provides:
Sidebar
componentprops
refactor todefaults
DefaultSidebar
toSimpleSidebar
HomeLayout
AppLayout
Core
componentCloses #213
Type of change
Please delete options that are not relevant.
Checklist: