Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

222 implement unit tests for the edit button component #223

Merged

Conversation

sgobotta
Copy link
Member

@sgobotta sgobotta commented Mar 7, 2020

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

This PR provides:

  • EditButton component refactor
  • Unit tests for the EditButton component
  • Updates DeleteButton tests

Closes #222

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Unit test

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce the cases. Please also list any relevant details for your test configuration

  • Unit tests
  • Manual testing in the UI

Checklist:

The following options in bold are required for a PR approval. Please check the boxes only if necessary, it help us minimizing the reviewing process.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov-io
Copy link

codecov-io commented Mar 7, 2020

Codecov Report

Merging #223 into develop will increase coverage by 0.5%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #223     +/-   ##
=========================================
+ Coverage    79.89%   80.4%   +0.5%     
=========================================
  Files           88      88             
  Lines          746     750      +4     
  Branches        17      17             
=========================================
+ Hits           596     603      +7     
+ Misses         148     145      -3     
  Partials         2       2
Impacted Files Coverage Δ
src/components/Actions/Show/defaults.js 0% <ø> (ø) ⬆️
src/components/Actions/List/List.vue 82.85% <ø> (ø) ⬆️
src/constants/ui.element.names.js 85.71% <ø> (ø) ⬆️
.../components/UiComponents/EditButton/EditButton.vue 100% <100%> (+50%) ⬆️
src/components/UiComponents/EditButton/index.js 100% <0%> (+50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68ec0e0...83a8ab0. Read the comment docs.

@sgobotta sgobotta merged commit cc77e04 into develop Mar 8, 2020
@sgobotta sgobotta deleted the 222-Implement-Unit-tests-for-the-EditButton-component branch March 8, 2020 00:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants