Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add customer examples for invoice pdf and medical report image #54

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

jojortz
Copy link
Contributor

@jojortz jojortz commented Oct 22, 2024

Feature
Add new demos:

  • pdf_to_key_value.ipynb and async_pdf_to_key_value.ipynb: Demo extracting key-value from example Invoice document
  • image_to_key_value.ipynb and async_image_to_key_value.ipynb: Demo extracting key-value pairs from example medical report image

Testing

  • ran automated tests in test/test.py via pre-commit
  • ran new notebooks

@jojortz jojortz requested a review from Sdddell as a code owner October 22, 2024 21:40
@CambioML
Copy link
Collaborator

Please fix broken test cases.

1 similar comment
@CambioML
Copy link
Collaborator

Please fix broken test cases.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should consider to put sensitive information even this in a S3 bucket and put a .env to ask people to put access key and secret key to download.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this issue addressed?

@CambioML
Copy link
Collaborator

Please fix broken test cases.

What is the status of the broken unittest?

@jojortz
Copy link
Contributor Author

jojortz commented Nov 2, 2024

All test cases passed.

This is already updated to be extract_key_value to match cambio-core.

TODO
Once the new extract_key_value is pushed to public, this will need to be updated as the output format has changed with cambio-core

Copy link
Member

@lingjiekong lingjiekong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lingjiekong lingjiekong merged commit e7c2d2d into main Nov 4, 2024
5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants