Checks for inconsistent device types #272
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #269.
This PR adds checks that overloaded operators are only applied to tensors that have the same device type.
It's sufficient to add the checks in the assignment operator and the binary operators as the unary operators will go through the assignment anyway.
The PR also adds checks that tensors have been constructed before they are interrogated. Related fix in the autograd example - the output tensor
Q
wasn't set up so didn't have a device type yet.Questions: