Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

v2.1.1 - fix keyframes #17

Merged
merged 1 commit into from
May 2, 2022
Merged

v2.1.1 - fix keyframes #17

merged 1 commit into from
May 2, 2022

Conversation

geoctrl
Copy link
Contributor

@geoctrl geoctrl commented May 1, 2022

fix kremling-postcss-plugin to allow for the @keyframe at-rule - basically the nested "steps" don't need to be scoped

what it used to do:

@keyframe custom-anim {
  [kremling=1]from, [kremling=1] from {
    background-color: red;
  }
  [kremling=1]to, [kremling=1] to {
    background-color: red;
  }
}

with the fix:

@keyframe custom-anim {
  from {
    background-color: red;
  }
  to {
    background-color: red;
  }
}

Copy link

@rhys-childs rhys-childs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This looks good. Without an animation duration I don't think this will actually apply the animation effect, that wont be an issue, right?

@geoctrl
Copy link
Contributor Author

geoctrl commented May 2, 2022

the postcss plugin will now skip "tags", so it won't matter if it's to or a percentage: 25%

@geoctrl geoctrl merged commit 1b3b16a into master May 2, 2022
@geoctrl geoctrl deleted the 2.1.1-fix-keyframes branch May 2, 2022 19:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants