Feature/details component #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ibabalola
commented
Oct 18, 2021
Ibabalola
commented
- created Details Component
- added Demo of Details Component
- added seperate section for 0.3 release component
- added storybook story for unstyled, styled, live and documentation
- added 100% test coverage for Range component
- renamed test.ts file name to test.tsx file
example/components/DetailsDemo.tsx
Outdated
| export const DetailsDemo = () => ( | ||
| <> | ||
| <h1>Simple Details Component</h1> | ||
| <Details details="detail information to shown" summary="summary headline" /> |
There was a problem hiding this comment.
it's slightly different from what we describe in the ticket. the main question I've is how I can put something more complex in the summary? If my hidden content is for example a table this component can't be used anymore
There was a problem hiding this comment.
Understood, updated to address the concern @daniele-zurico
<Details summary={ This can only be a string }> YOUR COMPONENT </Details>
daniele-zurico
approved these changes
Oct 22, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.