fix: allow closing of the Autocomplete results list with the Escape key instead of onBlur #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniele-zurico
approved these changes
Jan 17, 2023
daniele-zurico
added a commit
that referenced
this pull request
Jan 18, 2023
* feat: add value to button * feat:select-containerId (#350) * fix: On initial render, ensure that the input prompt for Autocomplete is not visible unless focused (#357) * Feature/upgrade deps (#359) * feat: upgrade deps * feat: downgrade microbundle * Autocomplete: Ensure the value of controlled input is never undefined (#358) * feat: upgrade microbundle (#360) * fix: Accessibility improvements (#361) * Feature/autocomplete (#364) * feat: add dynamic id to the list * feat: add dynamic id to the list * feat: change on the id * feat: remove jss dependecy (#365) * Make onChange prop optional for FormGroup component (#368) * feat: use sass library instead of node-sass * feat: onChange type now optional * Separate radio and checkbox groups (#380) * feat: remove <FormRadio> storybook (#369) * feat: Deprecate <FormRadio> (#370) * feat: remove <FormGroup /> and related stories * Task create form radio (#371) * feat: Deprecate <FormRadio> * feat: add <FormRadio /> component * feat: add <FormRadioCheckboxBase> component * feat: update dev script * feat: move <FormGroup /> to <FormRadio /> * feat: rename test FormGroup to RadioGroup * feat: add storybook documentation * feat: Rename StyledRadios to Styled * feat: Fix unstyled stories * Task create checkbox group (#373) * feat: create <CheckboxGroup /> component * feat: update test * feat: fix test. Was looking for wrong element * feat: update storybook documentation (#378) * feat: remove "unstyled" dir from radioGroup story * feat: update storybook doc for single checkbox (#381) * Correct single checkbox stories (#382) * feat: correct <FormCheckbox /> Stories * feat: correct <FormCheckbox /> Stories * feat: add class to fix styling (#383) * fix: add correct components to example src (#385) * feat: move elements outside of label (#387) * Conditionally render aria-label (#386) * feat: conditionally render aria-label * feat: unit test failed eslint checks * Feature/upgrade storybook (#392) * feat: update storybook * feat: update storybook * Feature/tab index (#389) * fix: tabIndex prop for Button CopyToClipboard Details and FormDate * fix: tabIndex type to string * fix: tabIndex back to number * fix: tabIndex and missing tests * fix: updated liveEdit files Co-authored-by: Daniele Zurico <daniele.zurico@gmail.com> * fix: allow closing of the options list with the Escape key instead of onBlur (#400) * Feat/update readme (#391) * Update CHANGELOG.md Co-authored-by: SergioBandera <113599747+SergioBanderaGarcia@users.noreply.github.com> Co-authored-by: Sri Viswanathan <sri@protodiv.com> Co-authored-by: cg-julian-taylor <107050226+cg-julian-taylor@users.noreply.github.com> Co-authored-by: Szilvi Horvath <szilvi.horvath@capgemini.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onBluron the text input was closing the results list, it was interrupting the click handler for the results list and this was the cause of issue Autocomplete: Selecting a dropdown option with the mouse no longer works #399onBluron the text input no longer closes the results list, so clicking outside has no effect anymore. However, we can now press theEscapekey to close it. Will need to come up with a different way of closing the results list if clicking outsideFixes #399