Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Storybook - cleanup css #418

Merged
merged 6 commits into from
Feb 21, 2023
Merged

Conversation

Jaya-Rathore
Copy link
Collaborator

@Jaya-Rathore Jaya-Rathore commented Feb 16, 2023

Issue : 408
Storybook cleanup the import
-Currently, every file in the stories folder has an import to /stories/style.css
-Storybook provide the ability to add that import only in the preview-head file

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (9fa33d3) compared to base (7fbc70e).
Patch has no changes to coverable lines.

❗ Current head 9fa33d3 differs from pull request most recent head ba8e75d. Consider uploading reports for the commit ba8e75d to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@              Coverage Diff              @@
##           release/0.7      #418   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files               45        45           
  Lines             1029      1029           
  Branches           400       400           
=============================================
  Hits              1029      1029           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Jaya-Rathore Jaya-Rathore marked this pull request as draft February 16, 2023 11:40
@Jaya-Rathore Jaya-Rathore marked this pull request as ready for review February 16, 2023 11:45
@daniele-zurico
Copy link
Contributor

closing for now given we agreed to put more enhancements

@Jaya-Rathore Jaya-Rathore reopened this Feb 21, 2023
@daniele-zurico daniele-zurico changed the title fix: {{ Storybook cleanup the import }} Storybook - cleanup css Feb 21, 2023
@daniele-zurico daniele-zurico merged commit cf21f21 into release/0.7 Feb 21, 2023
@daniele-zurico daniele-zurico deleted the feature/storybook-cleanup-import branch March 14, 2024 11:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants