-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
✨🍫 Add CocoaPods podspec #132
Conversation
Oh, LOL. I didn't see #122 🤦♂️ |
This looks great. 👍 |
Do you want to be in charge of pushing the podspec? Do I need to give you access to the repo to do that? |
Sure, I'll take care of pushing the spec to trunk. I'll also open an issue to track adding others to have access to publish updates. |
No, I don't need repo access to be able to publish the spec. In fact, the spec doesn't even need to be tracked in source control to publish, but obviously that's a best practice. I would like to become a contributor on this project as I'm starting another macOS CLI project and could help maintain it. |
It's live! https://cocoapods.org/pods/Commandant
|
Thanks @phatblat! Could you add me as the pod owner as well? My mail address is here: https://github.com/ikesyo. |
|
||
# s.xcconfig = { "HEADER_SEARCH_PATHS" => "$(SDKROOT)/usr/include/libxml2" } | ||
|
||
s.dependency "Result", "~> 4.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually wrong. At 0.14.0 this should be ~ 3.2
.
https://github.com/Carthage/Commandant/blob/0.14.0/Cartfile#L1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependencies are updated in #130 and not released yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, the spec can be patched
@ikesyo done! 🙌🏻 |
While working on mas-cli/mas#154 I noticed that Commandant doesn't support CocoaPods, so I created a podspec. This works, but I can clean it up if this is a direction you want to go in.
I see that this project supports Carthage and the SwiftPM, would you like to add CocoaPods? If so, the final step is to publish the spec to trunk. I am more than happy to help out and make sure the core contributors can all update the pod on release.
So, the cost of adding CocoaPods support is pretty low, but specifically involves the following:
pod lib lint
) to prevent regressionsCartfile*
Package.swift
Commandant.podspec
.podspec
filepod trunk push Commandant.podspec
by a contributor with permission to do soThoughts?