Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Expose a public initializer to NoOptions so that tests can be written for commands that take NoOptions #55

Merged
merged 1 commit into from
Feb 11, 2016

Conversation

younata
Copy link
Contributor

@younata younata commented Feb 11, 2016

Why was this not exposed earlier?

… commands that take NoOptions

Why was this not exposed earlier?
younata added a commit to younata/Carthage that referenced this pull request Feb 11, 2016
…test)

That test is failing while we wait for a couple of pull requests of mine to go through
Namely Carthage/Commandant#55 and Carthage#1114
@ikesyo
Copy link
Member

ikesyo commented Feb 11, 2016

Why not just call NoOptions<Error>.evaluate(.Usage)?

@younata
Copy link
Contributor Author

younata commented Feb 11, 2016

Because NoOptions<Error>() is infinitely more readable.

@mdiep
Copy link
Member

mdiep commented Feb 11, 2016

This seems fine. 👍

Why was this not exposed earlier?

I think it just wasn't obvious that it would be useful.

mdiep added a commit that referenced this pull request Feb 11, 2016
Expose a public initializer to NoOptions so that tests can be written for commands that take NoOptions
@mdiep mdiep merged commit f216157 into Carthage:master Feb 11, 2016
younata added a commit to younata/Carthage that referenced this pull request Feb 16, 2016
…test)

That test is failing while we wait for a couple of pull requests of mine to go through
Namely Carthage/Commandant#55 and Carthage#1114
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants