chore(bs,sf|constructors): update internal function used by ST_TILEENVELOPE #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jesus89
approved these changes
Jan 11, 2024
vdelacruzb
merged commit 8498143
into
chore/sc-237106/safe-make-remove-command
14 checks passed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tests on this PR #466 are failing due to recent updates in the default values of QUADBIN functions. Snowflake QUADBIN UDFs now return NULL for NULL arguments as it happens in Bigquery and as it was happening in some Quadbin Snowflake UDFs.
After seen the tests failing, I've discovered that in Bigquery we were still using the deprecated QUADINT functions to calculate the tile envelope.
Now ST_TILEENVELOPE returns
NULLfor null arguments. Unless we explicitly want to trigger an error.Type of change