Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(sf|quadbin): QUADBIN_TOPARENT not working with views #476

Merged

Conversation

vdelacruzb
Copy link
Contributor

Description

Shortcut

As stated by the snowflake team the issue seems to come from correlated subqueries which is not supported yet. I applied the same in QUADBIN_RESOLUTION. It would not be possible to apply this everywhere in quadbin as some functions require the use of CTEs

Type of change

  • Fix

Acceptance

SELECT
CARTO_DEV_DATA.carto.QUADBIN_TOPARENT(CARTO_DATA_ENGINEERING_TEAM.vdelacruz_carto.QUADBIN_FROMLONGLAT(long, lat, zoom), 6) AS parent
FROM 
CARTO_DATA_ENGINEERING_TEAM.vdelacruz_carto.coords_sample_filtered_view
;
-- Processing aborted due to error 300002:2328349570; incident 6556747.

SELECT
CARTO_DATA_ENGINEERING_TEAM.vdelacruz_carto.QUADBIN_TOPARENT(CARTO_DATA_ENGINEERING_TEAM.vdelacruz_carto.QUADBIN_FROMLONGLAT(long, lat, zoom), 6) AS parent
FROM 
CARTO_DATA_ENGINEERING_TEAM.vdelacruz_carto.coords_sample_filtered_view
;
-- Works

@vdelacruzb vdelacruzb requested a review from Jesus89 January 29, 2024 18:00
Copy link

@vdelacruzb vdelacruzb changed the title fix(sf|quadbin): quadbin toparent not working with views fix(sf|quadbin): QUADBIN_TOPARENT not working with views Jan 29, 2024
Copy link
Member

@Jesus89 Jesus89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Finally a way to skip (a bit) correlated subqueries 👍

@vdelacruzb vdelacruzb merged commit d31d3ed into main Feb 1, 2024
10 checks passed
@vdelacruzb vdelacruzb deleted the bug/sc-322469/research-quadbin-toparent-not-working-with branch February 1, 2024 09:01
@Jesus89 Jesus89 mentioned this pull request Feb 15, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants